I don’t mind when they stand by the door with donation tins, or when they have barbecue stalls outside where people can buy hotdogs, but I am always annoyed when they pack my groceries.
I find it an extremely pushy thing to do. I have never been asked if I would like this service, and it strikes me as very similar to squeegees, which are illegal.
Apart from having someone pack my groceries in a way that is likely less intentional than how I would do it, it is such a useless job and usually just adds congestion to the already very busy store.
I think if hockey teams are trying to do jobs to raise money, they should find a service that is valuable to people, like mowing lawns, and should ask if people would like the service giving the recipient the chance to say “no thank you” if that’s their preference.